search

firecmsco / firecms

Awesome Firebase/Firestore-based CMS. The missing admin panel for your Firebase project!
https://firecms.co
Other
1.14k stars 185 forks source link

Missing dependency in useCallback breaks text search #515

Closed Ziiiiiiiiit closed 1 year ago

Ziiiiiiiiit commented 1 year ago

In firebase_app/hooks/useFirestoreDataSource.ts, the useCallback of performTextSearch lacks the textSearchController as a dependency, This breaks text search for me as I am dependent on the textSearchController being able to change!

fgatti675 commented 1 year ago

Thank you @Ziiiiiiiiit , releasing a fix soon :)

fgatti675 commented 1 year ago

Fixed in version 2.0.5 :)

Ziiiiiiiiit commented 1 year ago

Thank you! I can confirm that it now works perfectly! :)