Hi, while running the master branch locally, I realized that my change in #1085 actually broke CI_REGISTRY_IMAGE. The reason is that the full string gets lowercased (i.e. something like $ci_registry/some/lowercased/path), which means $CI_REGISTRY does not get resolved (because the variable name was lowercased) 😅 . Thats what I get for not testing properly 🤦 .
I have added some tests now to make sure the behaviour is correct now (incidentally, I checked the gitlab source code and it seems they only lowercase the path, not the host, so this code matches the upstream behaviour more closely).
While writing the test I realized that CI_PROJECT_PATH_SLUG also needs to be lowercased to match the upstream behaviour.
Hi, while running the master branch locally, I realized that my change in #1085 actually broke
CI_REGISTRY_IMAGE. The reason is that the full string gets lowercased (i.e. something like$ci_registry/some/lowercased/path), which means$CI_REGISTRYdoes not get resolved (because the variable name was lowercased) 😅 . Thats what I get for not testing properly 🤦 .I have added some tests now to make sure the behaviour is correct now (incidentally, I checked the gitlab source code and it seems they only lowercase the path, not the host, so this code matches the upstream behaviour more closely).
While writing the test I realized that
CI_PROJECT_PATH_SLUGalso needs to be lowercased to match the upstream behaviour.Sorry for the trouble 😓