Closed ANGkeith closed 6 months ago
@firecow, i had some free time over the weekend.
Could you help to review the few small MRs, that i've opened.
Also, are you alright with utilizing the --preview
for the test cases?
This should make it easier to read write the expected
result and also speed up the tests
Its fine by me utilizing --preview
But I do have a problem with asserting the entire output is as expected, you end up with assertion roulette. https://testsmells.org/pages/testsmells.html#AssertionRoulette
In your case it's not that bad
make use of
--preview
in test cases to make it easier to write expected test output and also speed up test suites and fixes some yaml referenced tag's value did not get flattened which closes #954