feat: Maximum nested includes

firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?

MIT License

2.15k stars 125 forks source link

feat: Maximum nested includes #1123

Closed ANGkeith closed 5 months ago

ANGkeith commented 5 months ago

Implements https://docs.gitlab.com/ee/administration/settings/continuous_integration.html#maximum-includes and removed depth check as well as excludedGlob

Breaking changes:

refer to the include-local-wildcard test case.

ANGkeith commented 5 months ago

@PigeonF cherry-picked your test-cases https://github.com/firecow/gitlab-ci-local/pull/1122/commits/3f91cd137a61c5c68cbb186c3fe684ceedcf546f

PigeonF commented 5 months ago

I don't mind closing #1122 in favor of this PR.

firecow commented 5 months ago

@ANGkeith Eslint failing :smile:

ANGkeith commented 5 months ago

opps, my bad... test case fixed

firecow commented 5 months ago

@ANGkeith Do you want a collaborator invite, so you don't have to fork all the time?

hverlin commented 2 months ago

Can we just print a warning instead? I don't think the check here is accurate, as gitlab-ci-local fails to run a pipeline which works in our GitLab instance (at least it might count includes a bit differently?)

(Also, hard-coding it to 150 is not right. Maybe it should come from an env. variable as it can be configured in the GitLab admin)