firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?
MIT License
2.06k stars 118 forks source link

fix: cleanupJobResource #1150

Closed ANGkeith closed 4 months ago

ANGkeith commented 4 months ago

docker rm and docker volume rm supports multiple args.

this should probably be slightly more efficient.

Not too sure why, but the current cleanup also seemed to leave some docker volume undeleted

To replicated the issue:

# .gitlab-ci.yml
job0:
  image: bash
  script: echo hi
for i in $(seq 1 9); do
 gitlab-ci-local
done

Run docker volume ls and observe that there are remaing xxxxx-tmp volume that are not cleaned up

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud