firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?
MIT License
2.05k stars 118 forks source link

refactor(umask integration tests): use non root images instead of building it #1181

Closed ANGkeith closed 3 months ago

ANGkeith commented 3 months ago

a small refactor to the unit test as a pre-requisite to https://github.com/firecow/gitlab-ci-local/issues/1171

on a side note, should'nt --umask be default to false instead ? Which should be closer to gitlab-ci default

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ANGkeith commented 3 months ago

@firecow do you have any opinion on this ?

on a side note, should'nt --umask be default to false instead ? Which should be closer to gitlab-ci default