search

firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?
MIT License
2.03k stars 115 forks source link

refactor: rewrite unit-test to make it less dependent the stdout/stderr length #1185

Closed ANGkeith closed 2 months ago

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

firecow commented 2 months ago

@ANGkeith I was just about to ask you if you still wanted this in master :smile:

firecow commented 2 months ago

@ANGkeith Do you have something important in the pipeline in the next couple of days? If not, I'll prepare the 4.48.0 release

ANGkeith commented 2 months ago

@ANGkeith I was just about to ask you if you still wanted this in master 😄

Haha it was already merged in #1186

Was thinking about splitting the MRs to make it easier to review

firecow commented 2 months ago

@ANGkeith I was just about to ask you if you still wanted this in master 😄

Haha it was already merged in #1186

Was thinking about splitting the MRs to make it easier to review

Nah, your PR's are way easy to review :smile:

ANGkeith commented 2 months ago

@ANGkeith Do you have something important in the pipeline in the next couple of days? If not, I'll prepare the 4.48.0 release

yup please go ahead, thankss