fix: parsing of basic auth remote-url

[ANGkeith]

not too sure how to fix the code smell though

possible fix for #1178 and #921

[firecow]

https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&pullRequest=1202&id=firecow_gitlab-ci-local Have a look at the code smells @ANGkeith

I'll mark the security findings as safe.

[ANGkeith]

Have a look at the code smells @ANGkeith

yeah, i am aware of those code smells, not too sure how to fix it : x

They (named groups) are used, but the sonarqube seemed to fail to detect it.

[firecow]

Have a look at the code smells @ANGkeith

yeah, i am aware of those code smells, not too sure how to fix it : x

They (named groups) are used, but the sonarqube seemed to fail to detect it.

Oh... Then we shall ignore. I didn't think SonarQube could produce false positives. Never experienced that.

[firecow]

@ANGkeith I've fixed the code smells with https://github.com/firecow/gitlab-ci-local/pull/1202/commits/6f89d910437cc27036d5e8a1c88ef637bf6a1d95

[ANGkeith]

@ANGkeith I've fixed the code smells with 6f89d91

thanks!

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud