firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?
MIT License
2.03k stars 115 forks source link

feat: enable json schema validation by default #1232

Closed ANGkeith closed 1 month ago

ANGkeith commented 1 month ago

https://github.com/firecow/gitlab-ci-local/pull/1167#discussion_r1558871053

Whenever we're ready

firecow commented 1 month ago

Create a 5.x.x branch, and point this PR towards that.

That way we can manage all the breaking changes in the 5.x.x branch.

ANGkeith commented 1 month ago

hmm, why do you consider this a breaking change though, i see it more as a feature

firecow commented 1 month ago

@ANGkeith Well, if it doesn't break anything, I'm open to just merge it to master, and include it in the upcoming release.

Let me test it on our 50ish projects :smile:

ANGkeith commented 1 month ago

@ANGkeith Well, if it doesn't break anything, I'm open to just merge it to master, and include it in the upcoming release.

Let me test it on our 50ish projects 😄

nice, let me know how it goes

however, there's some edge case as per what @PigeonF discovered in https://github.com/firecow/gitlab-ci-local/pull/1229#issue-2309870744 .

It appears that GitLab.com is still able to process the .gitlab-ci.yml file even when it's provided with an invalid JSON schema.

firecow commented 1 month ago

@ANGkeith My 50ish projects had no problems, point this to master, and we will release in next minor version

If gitlab doesn't uphold their owm json schema rules, that's their problem :smile:

firecow commented 1 month ago

@ANGkeith Conflicts... :D I'll publish new version once this is in master.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud