Revisit if `types` is indeed an illegal name

[hverlin]

Minimal .gitlab-ci.yml illustrating the issue

---
types:
  script:
    - echo "test"

test:
  needs: [types]
  script:
    - echo "test"

Expected behavior According to the documentation, it should not work. https://docs.gitlab.com/ee/ci/jobs/#job-name-limitations

However, it does work: https://gitlab.com/hverlin/gitlab-ci-local-tests/-/pipelines/1324968259

Probably this is a limitation that they forgot to remove from the documentation?

> gitlab-ci-local
needs: [types] for test could not be found

Two solutions:

• remove types from: https://github.com/firecow/gitlab-ci-local/blob/ba3509a42b5e0155913fb09d0885c93284df1f39/src/job.ts#L69-L73
• add a warning to the console if a job name matches an invalid name

[ANGkeith]

hmm,

(personally i would prefer the 2nd solution, because can't really tell if gitlab.com forget to remove or are they reserving those word for future use

[ANGkeith]

speaking of which, gitlab-ci-local/src/job.ts

our list seemed to deviate a little from https://docs.gitlab.com/ee/ci/jobs/#job-name-limitations

[ANGkeith]

The following all works too eventhough the docs says it's illegal lols..

---
"true":
  script:
    - echo "test"

"false":
  script:
    - echo "test"

"nil":
  script:
    - echo "test"

[hverlin]

Filed an issue https://gitlab.com/gitlab-org/gitlab/-/issues/467170