Minor misleading typo in README.md

firecow / gitlab-ci-local

Tired of pushing to test your .gitlab-ci.yml?

MIT License

2.28k stars 128 forks source link

Closed stdedos closed 1 week ago

stdedos commented 2 weeks ago

There is a small technical error in the

suggestion.

They key is .asc (ASCII-armored) format, and not binary (i.e. .gpg)

Ofc it doesn't make a difference when piped, but it kinda does when you want to setup e.g.

deb [ signed-by=/etc/apt/sources.keyring.d/gitlab-ci-local-ppa.asc ] https://gitlab-ci-local-ppa.firecow.dk ./

(for older apt versions that do not support the verbatim Signed-By key of the Deb822 format)

firecow commented 2 weeks ago

@stdedos Make a PR man 😃

stdedos commented 2 weeks ago

Also kinda sorta you should update the filename on the server.

How about some ln -s-foo? 😄

PS: I'll send the PR later tonight

firecow commented 2 weeks ago

Can you be more specific on what you want updated? I'm confused :D @stdedos

stdedos commented 2 weeks ago

So I would ask you to rename the file pubkey.gpg to pubkey.asc.

However, I understand that you have been having the https://gitlab-ci-local-ppa.firecow.dk/pubkey.gpg URL public for some time - so you cannot "just remove it". So probably you will end up with both https://gitlab-ci-local-ppa.firecow.dk/pubkey.gpg and https://gitlab-ci-local-ppa.firecow.dk/pubkey.asc pointing at the same file

firecow commented 2 weeks ago

Aah.. I see.. We shall just have both.

Add a dublicate in your PR

stdedos commented 2 weeks ago

Add a dublicate in your PR

You mean

curl -s "https://gitlab-ci-local-ppa.firecow.dk/pubkey.asc" | sudo tee "${PPA_KEY_PATH}"

firecow commented 1 week ago

Wait a minute the file doesn't exists until next version, my bad :smile: