search

firecracker-microvm / firecracker-containerd

firecracker-containerd enables containerd to manage containers as Firecracker microVMs
Apache License 2.0
2.1k stars 180 forks source link

Investigate flakiness in TestBuildVMConfiguration/Container_Count_affects_StubDriveCount #584

Open ginglis13 opened 2 years ago

ginglis13 commented 2 years ago

see these builds from #576 in which TestBuildVMConfiguration/Container_Count_affects_StubDriveCount failed with each failure having the same diff: 

Diff:
                                --- Expected
                                +++ Actual
                                @@ -52,3 +52,3 @@
                                  MachineCfg: (models.MachineConfiguration) {
                                -  CPUTemplate: (models.CPUTemplate) (len=2) "C3",
                                +  CPUTemplate: (models.CPUTemplate) "",
                                   MemSizeMib: (*int64)(128),

Rerunning build succeeded.

kzys commented 2 years ago

It may be due to https://github.com/firecracker-microvm/firecracker-containerd/blob/004b92f9d1dea8830924e078285fceb86b17eb97/internal/cpu_template.go#L32?

https://github.com/actions/virtual-environments doesn't talk much about the underlying CPU vendor (Intel or AMD).