firecracker-microvm / firecracker-containerd

firecracker-containerd enables containerd to manage containers as Firecracker microVMs
Apache License 2.0
2.23k stars 182 forks source link

remove logcheck script from buildkite pipeline, use gh workflow instead #758

Closed swagatbora90 closed 1 year ago

swagatbora90 commented 1 year ago

Issue #, if available:

Description of changes:

Currently, DCO checks on new commit messages are being run in two places. Once, in the buildkite pipeline using the logcheck.sh script, another using git-validation during make lint which is run as part of the github workflow.

This removes the logcheck.sh script and only keeps the GH workflow. Buildkite is currently running on main branch only, so DCO check on buildkite is not really useful for newly create PRs. Keeping the GH workflow means that it can run on all new PRs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.