Open th0m opened 1 year ago
@vvejell1 can you please help review this PR when you have a moment? Thank you.
Hi @th0m , looks like buildkite tests (example) have not run:
Missing DCO on d88daf38557b97d2922471b123748fd6aa2480cc
could you please sign your commit ? if you've already got your name and email configured in git, you can git commit --amend -s
, then force push to this branch to update the PR
@ginglis13 I am getting build errors that seem unrelated to my change https://buildkite.com/firecracker-microvm/firecracker-go-sdk/builds/3007#01869a5d-b0c1-4d19-ad6f-156ddcc120f3/17-1015
@ginglis13 can you please have a look? Thanks
@th0m we've got an infrastructure bug we're addressing. As soon as it's resolved we can re-run and continue the review
@th0m I have a fix on CI failure merged into main. You can rebase, push and trigger the build again.
Thanks, build failures are on me now, I will fix them.
Ready for review @fangn2 thank you.
@ginglis13 I believe this is ready to go.
Our use case is to:
SetupNetworkHandler
ourselves to get the network configuration generated using a CNI pluginfirecracker.SetupNetworkHandlerName
andfirecracker.SetupKernelArgsHandlerName
from the list of defaultFcInit
handlersWith that in mind we want to be able to have more than one IP on interfaces and to support IPv6, which is what this change intends on achieving while keeping backwards compatibility.