search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
466 stars 123 forks source link

Upgrade firecracker to 1.4.1 #486

Closed fangn2 closed 11 months ago

fangn2 commented 1 year ago

Issue #, if available: Upgrade firecracker from 1.0.0 to 1.4.1

Description of changes: Upgrade firecracker to 1.4.1 https://github.com/firecracker-microvm/firecracker/compare/v1.0.0...v1.4.1 PR #495 has upgraded firecracker partially to 1.4.1(only snapshot memory backend was added, not all swagger specs were in sync with v1.4.1), this PR is a followup to make sure swagger files are in sync and client were generated.

  1. Pull swagger specs from firecracker 1.4.1
  2. go generate to rebuild the client
  3. Upgrade version in the Makefile

Missing features not yet implemented at sdk side are captured in the list.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Sign-off-by: Tony Fang nhfang@amazon.com

fangn2 commented 11 months ago

Waiting for #495 to merge to unblock build issue.

bduffany commented 11 months ago

Waiting for #495 to merge to unblock build issue.

I think my PR (#495) is dependent on upgrading Firecracker, since MemoryBackend is not available in Firecracker v1.0.0.

I can bump firecracker_version in the Makefile in my PR, if that's all that's needed. Let me know if I need to do anything else.

fangn2 commented 11 months ago

I can bump firecracker_version in the Makefile in my PR, if that's all that's needed. Let me know if I need to do anything else.

Thanks! From test perspetive, change that is enough to test with firecracker 1.4.0

fangn2 commented 11 months ago

Since firecracker 1.4.1 was released, upgrade to it directly. 1.4.0 to 1.4.1 has no swagger.yaml change.