search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
466 stars 123 forks source link

Allow `--cgroup` to be passed to `jailer` #493

Open gudmundur opened 1 year ago

gudmundur commented 1 year ago

Description of changes: When setting up the jailer via firecracker-go-sdk I noticed that the SDK only supported setting a WithNumaNode to provide affinity. This change allows the WithNumaNode to be optional, which it is with the jailer. This change also adds a WithCgroupArgs option that will pass the provided arguments through to jailers --cgroup argument.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

adityamaru commented 6 months ago

👋 I'm wanting the same thing, any reason you decided to not pursue this change? Is there a better way to configure cgroups via the SDK?

maxdml commented 5 months ago

Likewise, would love to see this in.

gudmundur commented 4 months ago

@adityamaru we're using this in production. Waiting for a maintainer here to review this. 😳

gs0510 commented 3 weeks ago

@swagatbora90 @austinvazquez Any chance y'all could look into it? Seems like you folks are the most recent contributors on AWS side. Thank you!

gs0510 commented 3 weeks ago

@sondavidb Thank you so much for taking a look at #574, could I ask you to take a look at this PR as well? Also, it seems like a bunch of folks would also like this PR landed. Thanks again!

sondavidb commented 3 weeks ago

@gudmundur could you rebase and push so the tests can run again?