search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
485 stars 123 forks source link

Upgrade minimum go to 1.17 #498

Closed fangn2 closed 1 year ago

fangn2 commented 1 year ago

Issue #, if available:

Description of changes: Upgrade minimum go to 1.17 to unblock dependency golang.org/x/net update PR #497 which requires go 1.17+. Currently it's failing with error:

go build -o snapshot-example
--
  | go: downloading golang.org/x/sys v0.8.0
  | # golang.org/x/sys/unix
  | ../../../../../../../go/pkg/mod/golang.org/x/sys@v0.8.0/unix/syscall.go:83:16: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/sys@v0.8.0/unix/syscall_linux.go:1018:20: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/sys@v0.8.0/unix/syscall_linux.go:2297:9: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/sys@v0.8.0/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/sys@v0.8.0/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
  | note: module requires Go 1.17
  | make: *** [Makefile:73: snapshot-example] Error 2
  | 🚨 Error: The command exited with status 2
  | user command error: exit status 2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fangn2 commented 1 year ago

Buildkite CI is failing on building Firecracker from tip of Firecracker's main branch which is not related to this change. The CI has been failing for the same reason in the last 9 consecutive nightly builds.