search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
466 stars 123 forks source link

Remove `addVsocksHandler` from `loadSnapshotHandlerList` #507

Open CuriousGeorgiy opened 10 months ago

CuriousGeorgiy commented 10 months ago

Issue #, if available: #506

Description of changes: According to the firecracker OpenAPI specification^1, creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways.

Closes #506

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CuriousGeorgiy commented 10 months ago

Should I add a test for this patch?

CuriousGeorgiy commented 10 months ago

/cc @fangn2 @swagatbora90 @bduffany