search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
466 stars 123 forks source link

Fix snapshotting example build #540

Closed pnasrat closed 2 months ago

pnasrat commented 3 months ago

Description of changes:

Updates go mod for 1.21, tc-redirect-tap, and cni plugins

Removes deleted dependency github.com/mitchellh/osext

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

With out this build fails:

$ make
go build -o snapshot-example
mkdir -p bin
GOBIN=/home/pnasrat/workspace/src/github.com/firecracker-microvm/firecracker-go-sdk/examples/cmd/snapshotting/bin go install github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093
go: github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093: version constraints conflict:
    github.com/awslabs/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093 indirectly requires github.com/mitchellh/osext@v0.0.0-20151018003038-5e2d6d41470f: github.com/mitchellh/osext@v0.0.0-20151018003038-5e2d6d41470f: invalid version: git ls-remote -q origin in /home/pnasrat/go/pkg/mod/cache/vcs/94ed57c5b21c953d93b47487113db43a5c9b69fd990329ec70dc77348c4dd443: exit status 128:
    fatal: could not read Username for 'https://github.com': terminal prompts disabled
Confirm the import path was entered correctly.
If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.
make: *** [Makefile:47: bin/tc-redirect-tap] Error 1
swagatbora90 commented 2 months ago

@pnasrat Thanks for your contribution. Please rebase the PR.

pnasrat commented 2 months ago

This was handled in the merge #546 which updates to 1.18 and also ran go mod tidy