search

firecracker-microvm / firecracker-go-sdk

An SDK in Go for the Firecracker microVM API
Apache License 2.0
466 stars 123 forks source link

Revert "Pass firecracker log level through jailer" #579

Closed swagatbora90 closed 1 week ago

swagatbora90 commented 1 week ago

This reverts commit fe672947d6eeda2d2c99ff1379a766cbc25e0fee.

Issue #, if available: Passing --log-level without passing log-path is not supported in firecracker v1.4.1. The above PR breaks that behavior resulting in CI failures. This behavior has been changed since firecracker v1.5.0, so we should be able to make the change once we update this SDK to support v1.5.0 api. But for now the behavior should remain consistent with v1.4.1 api.

Adding a separate issue #580 580 to track the addition of this change once we upgrade go-sdk to support firecracker v1.5.0

@gudmundur @austinvazquez

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gudmundur commented 4 days ago

@swagatbora90 Happy to provide a fix to this, is there a way I can see the results from the CI test suites?

swagatbora90 commented 4 days ago

Thanks @gudmundur. Here is the CI run that failed https://buildkite.com/firecracker-microvm/firecracker-go-sdk/builds/3712#01902801-d6d8-4913-ac88-149051653840