Remove `logger` dependency from devices crate

firecracker-microvm / firecracker

Secure and fast microVMs for serverless computing.

http://firecracker-microvm.io

Apache License 2.0

25.36k stars 1.76k forks source link

Remove `logger` dependency from devices crate #1760

Closed andreeaflorescu closed 1 year ago

andreeaflorescu commented 4 years ago

In terms of logging capabilities, the devices just need a way of calling the log macros: info!, warn!, error!. These ones are exported by the log crate which we also use when implementing the custom Firecracker logger. Instead of depending on the logger crate, we can instead take a dependency on log.

Depends on: #1759

AnishShah commented 3 years ago

Hi @andreeaflorescu, I would like to work on this issue. This looks like an easy issue. Can I get more details on what's needed here? I'm not sure why this issue is dependent on #1759. Thanks!

dianpopa commented 1 year ago

We do not have any plan to remove the logging capabilities from the devices crate as they are right now in a foreseeable future. Closing this.