search

firecracker-microvm / firecracker

Secure and fast microVMs for serverless computing.
http://firecracker-microvm.io
Apache License 2.0
24.53k stars 1.72k forks source link

use GuestMemory::read_from() and GuestMemory::write_to() in Vsock #2592

Closed serban300 closed 1 year ago

serban300 commented 3 years ago

As part of https://github.com/firecracker-microvm/firecracker/pull/2574 we refactored vsock in order to use vm-memory methods instead of raw pointers. For performance reasons and limitations related to our vm-memory wrapper crate we used GuestMemoryRegion::read_from() and GuestMemoryRegion::write_to()

After dirty bitmap tracking is merged in rust-vmm/vm-memory we should be able to use GuestMemory::read_from() and GuestMemory::write_to() directly.

alindima commented 2 years ago

While the performance aspect is fixed by #2661 , this issue is blocked by: https://github.com/rust-vmm/vm-memory/issues/171

roypat commented 1 year ago

With #3653 this no longer applies