firecracker-microvm / firecracker

Secure and fast microVMs for serverless computing.
http://firecracker-microvm.io
Apache License 2.0
25.38k stars 1.77k forks source link

Remove/hook unused metrics #2901

Open alindima opened 2 years ago

alindima commented 2 years ago

We have some metrics that are never incremented, for example: sync_response_fails and sync_vmm_send_timeout_count (I assume there are more). We should assess whether it's worth hooking them in the specific Firecracker code or just remove them.

roypat commented 11 months ago

There is some ongoing work to redesign our metrics subsystem to allow for per-device metrics by @sudanl0 at the moment, which will also tackle this issue.