search

firecracker-microvm / firecracker

Secure and fast microVMs for serverless computing.
http://firecracker-microvm.io
Apache License 2.0
25.88k stars 1.8k forks source link

Resolve untracked TODOs #3273

Open JonathanWoollett-Light opened 1 year ago

JonathanWoollett-Light commented 1 year ago

There a large number of relatively simple TODO comments in the code base, most do not have their own issues. This issue exist to track these.

To contribute, submit a PR resolving any TODO comment which does not have a linked issue and link your PR to this issue by including text like:

Resolves TODO: auto-generate kvm related structures with PartialEq on see #3273.

StonewallJohnson commented 1 year ago

Hello, I am a student from UT Austin and my group and I were wondering I we could work on this issue as part of our class assignment?

xmarcalx commented 1 year ago

Hi @StonewallJohnson ,

Thanks for your interest into Firecracker. Yes of course you can take this issue. We are not sure about specifically your class assignment and any relevance with this issue but definitely feel free to take this issue (or maybe part of it) and contribute toward!

Feel free to break down the tasks according relevant and self contained changes so also the maintainer will be able to easily review them.

VictoriaMen2a commented 1 year ago

Hi, I am in @StonewallJohnson 's group and would like to confirm that we are currently working on this issue!

andr3wy commented 6 months ago

Hi everyone,

We're a group at UT Austin and we're interested in picking this issue back up and finishing it.

JonathanWoollett-Light commented 6 months ago

HI @andr3wy the intention with this issue is to express there are various smaller tasks in TODOs within the code base, where each of these small tasks can be a separate small PR.

For example one of these TODOs is:

// TODO Use `#[derive(Debug)]` when a new release of
// [rust-timerfd](https://github.com/main--/rust-timerfd) is published that includes
// https://github.com/main--/rust-timerfd/pull/12.

this would be a PR that would update the rust-timerfd version and replace impl fmt::Debug for Balloon with #[derive(Debug)].