search

firecracker-microvm / firectl

firectl is a command-line tool to run Firecracker microVMs
Apache License 2.0
477 stars 72 forks source link

Add Docker rule to Makefile, update build documentation #13

Closed bgammill closed 5 years ago

bgammill commented 5 years ago

Description of changes:

  1. Added a Docker rule to the Makefile for users without Go locally installed.
  2. Updated build documentation to reflect the options available for building.
  3. Added explicit instructions for the build options.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bgammill commented 5 years ago

I was motivated to make these changes after running into issues with a local installation of Go. This should streamline the process of creating a binary for users that just want to clone the repo and quickly get working.

samuelkarp commented 5 years ago

@bgammill Thanks for addressing some of my comments. Are you planning to address the other comments as well?

bgammill commented 5 years ago

Should be good to go on those comments.

samuelkarp commented 5 years ago

@bgammill It looks like you have not addressed my remaining comments. Can you do so?

samuelkarp commented 5 years ago

@bgammill Thank you so much for your contribution! I've carried over your changes into https://github.com/firecracker-microvm/firectl/pull/38.