search

firecracker-microvm / firectl

firectl is a command-line tool to run Firecracker microVMs
Apache License 2.0
477 stars 72 forks source link

Adds simple integration test #26

Closed xibz closed 5 years ago

xibz commented 5 years ago

A very basic integration test that ensures that communication can occur on the unix socket.

Signed-off-by: xibz impactbchang@gmail.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

xibz commented 5 years ago

@nmeyerhans - Thanks for the comments! Resolved them.

xibz commented 5 years ago

@samuelkarp - Fixed up the issues and thanks for the SIGTERM vs SIGQUIT explanation!

nmeyerhans commented 5 years ago

@samuelkarp - Fixed up the issues and thanks for the SIGTERM vs SIGQUIT explanation!

Except that is the default behavior, but not the behavior of this application. In the signal handlers set up in machine.go (see installSignalHandlers()), INT and TERM are translated to CtrlAltDel events to the VM, which may or may not actually translate that event into a VM termination. SIGQUIT actually results in a hard shutdown of firecracker, which is why that's what I suggested we use here.

samuelkarp commented 5 years ago

In the signal handlers set up in machine.go (see installSignalHandlers()), INT and TERM are translated to CtrlAltDel events to the VM, which may or may not actually translate that event into a VM termination. SIGQUIT actually results in a hard shutdown of firecracker, which is why that's what I suggested we use here.

@nmeyerhans That makes sense. @xibz, SIGQUIT is appropriate to use here, but needs an explanatory comment like the one @nmeyerhans provided.

xibz commented 5 years ago

@nmeyerhans and @samuelkarp - Done