search

firecracker-microvm / firectl

firectl is a command-line tool to run Firecracker microVMs
Apache License 2.0
472 stars 73 forks source link

Updated firecracker go SDK to last version #46

Closed Zyqsempai closed 4 years ago

Zyqsempai commented 4 years ago

Signed-off-by: bpopovschi zyqsempai@mail.ru Issue #45

Description of changes: Updated firecracker go SDK to last version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Zyqsempai commented 4 years ago

@nmeyerhans Hi, I assume we need to update Firecracker in CI tools, to make build work again.

nmeyerhans commented 4 years ago

So, the error that you're seeing the tests is what firectl shows when the configured firecracker executable doesn't exist. By default it looks for "firecracker" via PATH. I've opened #48 to update the test environment to ensure that "firecracker" does exist in the PATH. If you rebase against the commits in that PR, your tests should pass.

We should improve our testing around the handling of the firecracker binary location. Expansion of PATH should work (and we should provide a better error in case it doesn't!) and we should ensure that specifying alternate location via the --firecracker-binary option also works.

Zyqsempai commented 4 years ago

@nmeyerhans Great, thank you, PTAL

Zyqsempai commented 4 years ago

@nmeyerhans Ping!

nmeyerhans commented 4 years ago

Merged as f3cbc14d09eb214f95fa6a743767df2cb4ed739f. It got a different SHA because the buildkite changes you rebased over got a different SHA themselves by the time they were merged. I dropped that commit, and just merged your change.

Thank you for your contribution, and I apologize for the delay in merging it!