installSignalHandlers: fix signal names in logs

angristan commented 3 years ago

Description of changes:

I'm not sure if this is an oversight or if this is intentional.

That being said, If run:

✅ killall -s SIGINT firectl, it prints INFO[0009] Caught SIGINT, requesting clean shutdown
❌ killall -s SIGTERM firectl, it prints INFO[0009] Caught SIGINT, requesting clean shutdown
❌ killall -s SIGQUIT firectl, it prints INFO[0012] Caught SIGTERM, forcing shutdown

I replaced them with s.String() instead 🤔

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kzys commented 3 years ago

Looks good to me. Can you add Signed-off-by line with your name as like other commits?

angristan commented 3 years ago

Should be good 👍

kzys commented 3 years ago

Thanks! Let me take a look the build failure.

kzys commented 3 years ago

Retried and succeeded. Thanks!

firecracker-microvm / firectl