Update build instructions in README

firecracker-microvm / firectl

firectl is a command-line tool to run Firecracker microVMs

Apache License 2.0

477 stars 72 forks source link

Update build instructions in README #7

Closed whalesalad closed 5 years ago

whalesalad commented 5 years ago

Description of changes:

go get is a required prerequisite for building the project that might hang up folks unfamiliar with Go's dependencies.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

samuelkarp commented 5 years ago

Are you using Go 1.11? Go 1.11 should automatically get all of the dependencies when you run go build (which is what make does).

whalesalad commented 5 years ago

Ah, interesting. I believe the version I have here is 1.10 on Ubuntu 18.10.

Feel free to close this if it’s not relevant any longer. Then again a lot of distributions aren’t up to date as far as package management goes so maybe it’s good to be explicit?

samuelkarp commented 5 years ago

Thanks, I'm going to close this as we require Go 1.11 (for use with vsock) and we build with modules (a Go 1.11 features).