firecracker-microvm / firectl

firectl is a command-line tool to run Firecracker microVMs
Apache License 2.0
467 stars 73 forks source link

Expand the GitHub actions matrix #94

Closed austinvazquez closed 1 year ago

austinvazquez commented 1 year ago

Issue #, if available:

Description of changes:

Add the latest Go compiler versions and OS images to the GitHub actions matrix.

Requires #92 and #93

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Austin Vazquez macedonv@amazon.com

sparr commented 1 year ago

This will quadruple the number of build jobs. Will that have any undesirable side effects?

austinvazquez commented 1 year ago

This will quadruple the number of build jobs. Will that have any undesirable side effects?

Certainly worth the spot checks for each compiler version we support. You can argue the OS image doesn't gain much value because the kernel version in each image is the same.

austinvazquez commented 1 year ago

Closing in favor of #98.