firedancer-io / firedancer

Firedancer is Jump Crypto's Solana consensus node implementation.
https://firedancer.io
Other
763 stars 127 forks source link

support https in snapshot loader #2183

Open lidatong opened 5 days ago

ripatel-fd commented 5 days ago

To add some context, we'll need to download snapshots over HTTPS.

@mmcgee-jump For this one, I suggest dynamically linking libssl via dlopen. What do you think?

libssl is typically tightly integrated with the OS (CA certs, etc) and is not guaranteed to be OpenSSL. Other benefits of not statically linking are not having to include the OpenSSL release lifecycle into Firedancer and a leaner binary size (less gadgets, etc). So, we'd just vendors the headers and try to load an OpenSSL at runtime into the snapshot tiles. If it fails, we can gracefully error out.

mmcgee-jump commented 5 days ago

Best to just statically link OpenSSL IMO