search

firedancer-io / firedancer

Firedancer is Jump Crypto's Solana consensus node implementation.
https://firedancer.io
Other
763 stars 127 forks source link

treap_buffer: Allocate some buffer room #2244

Open jumpsiegel opened 3 days ago

jumpsiegel commented 3 days ago

lets give ourselves some space for if you have 64 voters and want to add 1 more

anarcheuz commented 3 days ago

@jumpsiegel just wondering, is it maybe possible that more than 1 element past the real size is added to the treap ? since for some of the changes we are using values such as 1_000 in the fd_ulong_max(...), couldn't we also change FD_VOTE_AUTHORIZED_VOTERS_MIN and FD_STAKE_HISTORY_MIN to a big value too ?