firedancer-io / radiance

Solana protocol playground supporting Firedancer development
Apache License 2.0
92 stars 22 forks source link

Sigverify Edge Cases #40

Open ripatel-fd opened 1 year ago

ripatel-fd commented 1 year ago

Can we be sure that crypto/ed25519 performs exactly the same malleability checks as ed25519-dalek verify_strict?

https://hdevalence.ca/blog/2020-10-04-its-25519am

We should probably add test fixtures for edge cases.

leoluk commented 1 year ago

According to the post, this Go package does malleability checks: https://github.com/hdevalence/ed25519consensus

Haven't found any information on what the current status of the stdlib implementation is.

I'm not sure if it actually matters for transaction verification outside of consensus use cases.