search

firedigger / osuReplayAnalyzer

41 stars 7 forks source link

Detected incorrect number of misses #15

Open ThereGoesMySanity opened 7 years ago

ThereGoesMySanity commented 7 years ago

I ran Cookiezi's HDHR choke on Blue Zenith through the program and it detected 4 misses as opposed to 2. It looks to me like the CS equation might not be totally correct.

EDIT: After doing some testing of my own, I don't think it's the CS equation.

firedigger commented 7 years ago

Yeah, honestly, when I was checking myself it looked like float error, but I am not sure myself really.

ThereGoesMySanity commented 7 years ago

Changing the shift value to 0 gets rid of all of the false misses.

EDIT: the highest I could get it to without false misses was 1.5

firedigger commented 7 years ago

What do you mean by "shift"?

ThereGoesMySanity commented 7 years ago

the offset for stacks - it's called shiftValue in Beatmap.cs

firedigger commented 7 years ago

Stack shift is there for a reason though - in the game stacked notes have slight different coordinates. I think that my stack calculation might be incorrect, causing this, will figure it out eventually.