firedrakeproject / asQ

A library for implementing ParaDIAG timestepping algorithms using Firedrake
MIT License
4 stars 1 forks source link

`ufl.split` no longer works for `TensorProductElement` #107

Open JHopeCollins opened 1 year ago

JHopeCollins commented 1 year ago

A recent ufl PR#122 changed the logic in split, so splitting TensorProductElements which are not part of MixedElements now fails (see firedrake/ufl issue #33 and asQ PR #106). This isn't particularly bad for us for now because for NWP models we always use mixed spaces, but it has broken some of our tests.

We should try to get this fixed in UFL, and reinstate the failing tests in asQ once this happens.