Refactor DiagFFTPC.apply into smaller methods

firedrakeproject / asQ

A library for implementing ParaDIAG timestepping algorithms using Firedrake

MIT License

4 stars 1 forks source link

Open JHopeCollins opened 2 years ago

JHopeCollins commented 2 years ago

The DiagFFTPC.apply() method is currently quite long. This function applies the paradiag 3-step, so could be split up into three methods:

diagonalise / to_eigenbasis
block_solves
undiagonalise / from_eigenbasis This would be clearer, and allow for finer-grained testing.