search

firedrakeproject / asQ

A library for implementing ParaDIAG timestepping algorithms using Firedrake
MIT License
4 stars 1 forks source link

DO NOT MERGE: Fix the test failures on CI #91

Closed JHopeCollins closed 1 year ago

JHopeCollins commented 1 year ago

Two test failures to fix:

  1. Parallel test setup. This is breaking because Firedrake updated/fixed how they run parallel tests, so don't need to pin pytest to an old version. We just need to update our conftest.py to match theirs. Originally done in the memory_profiling branch and cherry-picked here so
  2. The Williamson5 timeseries test is hanging. This test was written a while ago so the style is a bit out of date. This should be updated to use the ComparisonMiniapp instead, which will calculate the error of paradiag vs the serial solution. Changing to Galewsky to avoid the nasty initial conditions of Williamson5 is also probably a good idea
JHopeCollins commented 1 year ago

This PR was branched of #90 because that was a (relatively small) branch where the tests were failing. Now I have the CI tests passing I have moved the relevant commits to PR #92, which is branched off master. This means that it can be merged straight in to master without relying on #90 being merged and then pushed into the other open branches.