search

firedrakeproject / fiat

This is FIAT. FIAT was previously maintained as part of the FEniCS project (https://github.com/fenics/fiat)
GNU Lesser General Public License v3.0
5 stars 7 forks source link

FIAT reluctant to create high-order quadrature rules #9

Closed miklos1 closed 7 years ago

miklos1 commented 7 years ago

Because of this sanity check. However, high order quadrature degrees are completely legitimate when solving for high-order discretisations. @wence-: what should we do?

wence- commented 7 years ago

This was a sanity check I put in because people kept on creating non-polynomial integrands that had ludicrous estimated degrees and so the quadrature was massive overkill. I agree that these schemes are entirely legit for high-degree elements. Shall we just remove it?

wence- commented 7 years ago

Perhaps we could add a warning in the form compiler if the estimated degree is more than a factor 10 (?) larger than the degree of the test/trial spaces?

dorugeber commented 7 years ago

I approve

miklos1 commented 7 years ago

Thanks, this sounds good.

miklos1 commented 7 years ago

Fixed in upstream master. firedrakeproject/tsfc#128 is adding a better alternative.