firedrakeproject / firedrake

Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)
https://firedrakeproject.org
Other
482 stars 157 forks source link

Fix cython type fails #3599

Closed Ig-dolci closed 4 weeks ago

Ig-dolci commented 4 weeks ago

Description

I encountered type-related errors in Cython in the firedrake installation with the JDBettedridge/python312 branch locally on Arch Linux. With the current fixings, the Firedrake installation worked.

JDBetteridge commented 4 weeks ago

Is this PR a duplicate of this branch: https://github.com/firedrakeproject/firedrake/tree/JDBetteridge/petsc_update

Ig-dolci commented 4 weeks ago

Is this PR a duplicate of this branch: https://github.com/firedrakeproject/firedrake/tree/JDBetteridge/petsc_update

Yes, I have verified that this PR is duplicated with your branch https://github.com/firedrakeproject/firedrake/tree/JDBetteridge/petsc_update. I just verified that line 2556 of this PR also agrees. So, I will be sure to close this PR.