BUG: Integration on facets fails in hexahedral meshes

[enricofacca]

Describe the bug If I understood correctly, there was a recent update to the tsfc repository #https://github.com/firedrakeproject/tsfc/commit/1944432ab023e009bf159fe5598ce89091419d19 that should make possible to compate integrals on facets in hexahedral meshes. Before it was not supported.

However, the following MVE produces the error messages shown below. The same error occurs using ds (external facets ) in place of dS.

Enrico

from firedrake import *

mesh = UnitCubeMesh(2,2,2,hexahedral=True)

W = FunctionSpace(mesh, "DQ", 0)
u = Function(W)
v = TestFunction(W)

h = CellSize(W.mesh())
h_avg = (h('+') + h('-'))/2

a_dg = - 4.0/h_avg * jump(u)* jump(v) * dS
A = assemble(a_dg)

Error message

File "/home/firedrake/firedrake/src/tsfc/tsfc/fem.py", line 115, in use_canonical_quadrature_point_ordering
    return isinstance(self.fiat_cell, UFCHexahedron) and self.integral_type in ['exterior_facet', 'interior_facet']
                                                         ^^^^^^^^^^^^^^^^^^
AttributeError: 'PointSetContext' object has no attribute 'integral_type'

Environment:

• OS: Ubuntu
• Python version: 3.12.3

• Output of Firedrake Configuration: package_manager: False minimal_petsc: False mpicc: /home/firedrake/petsc/packages/bin/mpicc mpicxx: /home/firedrake/petsc/packages/bin/mpicxx mpif90: /home/firedrake/petsc/packages/bin/mpif90 mpiexec: /home/firedrake/petsc/packages/bin/mpiexec disable_ssh: True honour_petsc_dir: True with_parmetis: False slepc: True packages: ['git+ssh://bitbucket.org/pefarrell/fascd.git@master#egg=fascd', 'git+ssh://github.com/firedrakeproject/gusto.git@main#egg=gusto', 'git+ssh://github.com/icepack/icepack.git#egg=icepack', 'git+ssh://bitbucket.org/pefarrell/fascd.git@master#egg=fascd', 'git+ssh://github.com/FEMlium/FEMlium.git@main#egg=FEMlium', 'git+ssh://github.com/g-adopt/g-adopt.git@master#egg=gadopt', 'git+ssh://github.com/icepack/icepack.git#egg=icepack', 'git+ssh://github.com/firedrakeproject/asQ.git@master#egg=asQ', 'git+ssh://github.com/firedrakeproject/gusto.git@main#egg=gusto', 'git+ssh://github.com/firedrakeproject/Irksome.git#egg=Irksome', 'git+ssh://github.com/thetisproject/thetis#egg=thetis', 'git+ssh://github.com/g-adopt/g-adopt.git@master#egg=gadopt', 'git+ssh://github.com/firedrakeproject/Irksome.git#egg=Irksome', 'git+ssh://github.com/thetisproject/thetis#egg=thetis', 'git+ssh://github.com/FEMlium/FEMlium.git@main#egg=FEMlium', 'git+ssh://bitbucket.org/pefarrell/defcon.git@master#egg=defcon', 'git+ssh://github.com/firedrakeproject/asQ.git@master#egg=asQ', 'git+ssh://bitbucket.org/pefarrell/defcon.git@master#egg=defcon'] honour_pythonpath: False opencascade: False torch: cpu jax: cpu petsc_int_type: int32 cache_dir: /home/firedrake/firedrake/.cache complex: False remove_build_files: False with_blas: None netgen: True Additions: None Environment: PYTHONPATH: None PETSC_ARCH: default PETSC_DIR: /home/firedrake/petsc Status of components:

  |Package |Branch |Revision |Modified |

  |FEMlium |main |7810749 |True | |FInAT |master |d8836d5 |True | |Irksome |master |1ecf180 |True | |PyOP2 |master |31471a60 |False | |asQ |master |fad5ccc |True | |defcon |master |da0864d |True | |fascd |master |2004948 |True | |fiat |master |d167922 |True | |firedrake |master |ed826a575 |False | |g-adopt |master |ef38dba |True | |gusto |main |cdd29825 |True | |h5py |firedrake |db2ab02f |True | |icepack |master |cc65af5 |True | |libsupermesh |master |1eccc99 |True | |loopy |main |b2c485f3 |True | |pyadjoint |master |167619a |True | |pytest-mpi |main |ee30587 |True | |thetis |master |8c6f9d1e |True | |tsfc |master |e06308d |True | |ufl |master |0ae483bd |True |

[connorjward]

@ksagiyam can you take a look?

[ksagiyam]

Could you check if https://github.com/firedrakeproject/tsfc/pull/331 fixes your issue?