firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.
http://firedrakeproject.org/gusto/
MIT License
12 stars 11 forks source link

Hydrostatic imbalance diagnostic needs work #336

Open tommbendall opened 1 year ago

tommbendall commented 1 year ago

The hydrostatic imbalance diagnostic does not include the effects of moisture, and it may be sensible for us to ensure that it uses the same solver and problem as is used for computing the pressure gradient / gravity terms. It is only implemented for the compressible equations.

tommbendall commented 1 year ago

The current implementation of this uses the reference profiles to check for imbalance, but it would be better not to do this. We should also: