Potential improvements to inner loop of SIQN timestepper

firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.

http://firedrakeproject.org/gusto/

MIT License

12 stars 11 forks source link

Closed tommbendall closed 1 week ago

tommbendall commented 8 months ago

There are some changes we could explore with the inner loop of the SIQN timestepper:

updating the reference profile, as suggested in #484
setting the density and temperature residuals to zero when not in the first inner iteration (as is done in GungHo)
explore setting xnp1 to be xp+xrhs_phys for the first outer iteration and inner iteration

tommbendall commented 2 months ago

This will have been addressed by #536, #539 and #542

tommbendall commented 1 week ago

As all of #536, #539 and #542 have been merged, this can be closed