search

firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.
http://firedrakeproject.org/gusto/
MIT License
12 stars 11 forks source link

Entropy #496

Closed Witt-D closed 5 months ago

Witt-D commented 7 months ago

Added entropy diagnostics for compressible euler equations

tommbendall commented 7 months ago

It looks like this branch already includes all of the vorticity diagnostic changes, and these now conflict with changes on main.

This means that this will either have to wait for the vorticity diagnostic (and you'll probably have to fix conflicts twice) or you could reimplement the vorticity diagnostic on a branch that comes cleanly off main?

I think the entropy changes themselves look good but it'll be easier to see in a clean branch