firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.
http://firedrakeproject.org/gusto/
MIT License
12 stars 11 forks source link

Mixed order recovery #524

Closed Witt-D closed 3 months ago

Witt-D commented 3 months ago

Code to build/find the necessary spaces for recovered transport for lowest order / mixed order finite element domains.

Spaces are found and build bespoke to the family of the de-Rham complex

jshipton commented 3 months ago

Great - thanks @Witt-D ! We need a / some tests(s) for this - I can't see that the new code is currently used anywhere...

tommbendall commented 3 months ago

Great - thanks @Witt-D ! We need a / some tests(s) for this - I can't see that the new code is currently used anywhere...

I think we could use this in some existing tests:

And if we want to be really thorough, we should add a unit-test specifically testing that the spaces set up have the appropriate degrees

jshipton commented 3 months ago

@tommbendall do we need an integration test or example that sets up and runs a problem on mixed order spaces?

tommbendall commented 3 months ago

@tommbendall do we need an integration test or example that sets up and runs a problem on mixed order spaces?

We could add a travelling vortex to the examples? But I think that could also happen in a different PR