firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.
http://firedrakeproject.org/gusto/
MIT License
10 stars 10 forks source link

Rotation should be included in the linear solver #532

Closed tommbendall closed 1 week ago

tommbendall commented 1 month ago

The Coriolis force is not included in any of our linear solvers, but it is included in GungHo's. I am optimistic that this may explain the instability of our 2x2 formulations, which I've only seen in 3D models including rotation.

colinjcotter commented 1 month ago

Oh! Either that's a regression or I had forgotten about it.

tommbendall commented 1 week ago

Closing as this was addressed by #539