firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.
http://firedrakeproject.org/gusto/
MIT License
10 stars 10 forks source link

Reorganise prescribed transport #533

Closed tommbendall closed 1 month ago

tommbendall commented 1 month ago

This reorganises the prescribed transport to allow more complicated methods for defining the transporting velocity.

The transporting velocity is now set up after the stepper, and can be done through three methods:

The main motivation is that sometimes we want more complicated methods for defining the transporting velocity, e.g.:

  1. specifying the time-varying velocity through a stream function, by interpolating into the H1 space then projecting gradperp(psi)
  2. the velocity is discontinuous in time. These cases cannot be handled with a single expression and so need something more complicated

It also has the nice benefit that time-varying winds are now set up after the timestepper, allowing the wind to be defined with the initial conditions.