search

firedrakeproject / tsfc

Two-stage form compiler
Other
15 stars 25 forks source link

Remove coefficients from ExpressionKernel #268

Closed connorjward closed 2 years ago

connorjward commented 2 years ago

This should be useful to do because UFL coefficients are large data structures which until now have inhibited caching of the generated ExpressionKernel.

wence- commented 2 years ago

Does this need to go concurrently with something in Firedrake?

connorjward commented 2 years ago

Does this need to go concurrently with something in Firedrake?

Yes. https://github.com/firedrakeproject/firedrake/pull/2348/commits/1c18e827d319e57fbdbb3e581c411ed779ef1cc8 from https://github.com/firedrakeproject/firedrake/pull/2348.

connorjward commented 2 years ago

It also needs this bugfix