fireduck64 / jelectrum

An Electrum Server written in Java
MIT License
41 stars 15 forks source link

Missing count value blockchain.block.headers #31

Closed HashEngineering closed 3 years ago

HashEngineering commented 3 years ago

Regarding these changes in Electrum: https://github.com/spesmilo/electrum/commit/d19ff4326601ea0b2da6d57ba9a42e8e142ccb8f

The issue #30 was fixed, but there is another issue with a missing value count in the response to a blockchain.block.headers message.

In the above commit, on a particular line count is required: https://github.com/spesmilo/electrum/commit/d19ff4326601ea0b2da6d57ba9a42e8e142ccb8f#diff-4e452488a453f6ab6d869a6a006bfa23457727da1354a9f7a23126fc20f9842eR589

According to this, count was added with 1.4.1 https://electrumx.readthedocs.io/en/latest/protocol-methods.html#blockchain-block-headers

This issue doesn't prevent connectivity, but shows up in the log output of the Electrum client.

There could be other issues with the latest version of software that is compatible with electrum protocol 1.4.1.