firefly-cpp / NiaAML

Python automated machine learning framework.
MIT License
29 stars 12 forks source link

69 support for regression tasks and feature selection #93

Closed LaurenzBeck closed 2 months ago

LaurenzBeck commented 2 months ago

๐Ÿ™‡๐Ÿ’– Thank you for contributing to NiaAML!

๐Ÿ’ฌ Description

This PR adds pipeline components to solve regression tasks to NiaAML. The additions have been implemented in such a way, that existing classification code does not have to be updated. -> This PR represents a minor version bump.

โ— Issue Links

Closes #69

๐Ÿงช How Has This Been Tested?

Unit tests have been added to

โœ… Checklist

LaurenzBeck commented 2 months ago

I do not really get why the "NiaAML / build (macos-latest, 3.10) (pull_request)" action fails.

I had a look at the details and it is using poetry run pytest, even though the developer guide suggests using poetry run coverage run --source=niaaml -m unittest discover -b

I tried both locally and they both pass.

Do you know what I can do to make it pass in the github actions @firefly-cpp ?

firefly-cpp commented 2 months ago

I am still trying to figure out the macos problem. However, we may exclude 3.10 version of Python. What do you think?

LaurenzBeck commented 2 months ago

Please also add detailed instructions in the documentation about adding a new regressor to this package.

I added an example section and instructions in the README.md.

Do you want me to add the same passage to the sphynx documentation in docs/?

I am still trying to figure out the macos problem. However, we may exclude 3.10 version of Python. What do you think?

I don't think the problem is with the python version, but I may be wrong there. In my opinion supporting >=3.11 should be fine, as we are already approaching the 3.13 release :)

firefly-cpp commented 2 months ago

Please update also sphinx. Definitely, let's go for > 3.10.