firefly-cpp / sport-activities-features

A minimalistic toolbox for extracting features from sports activity files written in Python
MIT License
17 stars 11 forks source link

Fix version of tcx2gpx on "0.1.4" due to PEP 604 incompatibility. #165

Closed KukovecRok closed 9 months ago

KukovecRok commented 9 months ago

Regarding #164 , updated workflow to include req.txt, pyproject.toml, poetry.lock, requirements.txt

This happens only on windows github runner, locally it is fine.

It seems that due to PEP 604 there are errors in tests, when calling library tcx2gpx. It is using ruff for linting, therefore it is using the latest Python Enhancement Proposals. It is unknown if this works with version of python <3.11.

I've fixed the version of tcx2gpx to 0.1.4 for now, since the only main difference in newer version is using ISO timestamps. Also tried with "from future import annotations", but this should be in the original library to prevent version mishaps. Maybe check where iPython version points to? Python is 3.10 or 3.11.

Added tests that uses pip install from requirements.txt instead of poetry for windows.